Remove process.exit(1); for npm install.#79
Open
abetwothree wants to merge 1 commit intoimagemin:mainfrom
Open
Remove process.exit(1); for npm install.#79abetwothree wants to merge 1 commit intoimagemin:mainfrom
abetwothree wants to merge 1 commit intoimagemin:mainfrom
Conversation
This line is causing many people to stop from being able to deploy. (see this issue imagemin#78) Can this be changed to determine whether libpng-dev can be installed on the system and stop the process if it can be installed with a warning to the user to install libpng-dev, else just continue on installing npm packages? It seems that systems with a commad of apt-get have access to libpgn-dev. This line is literally stopping the deployment of apps on systems where libpng-dev cannot be installed. I am on CentOS and there is no libpng-dev package for that system. Thank you!
wawanopoulos
approved these changes
Mar 18, 2018
|
Yes. I am having the same issue. A warning to the user would be better than this exiting. And we cannot reference a lower version of this as well. As this is a dependency of a dependency of a dependency. Changes to this would be much appreciated. |
|
Is anyone looking into this, or do we have to come up with our own solutions? It is difficult for our project as it is an inner dependency, which means I can't solve it from code alone without committing node-modules and altering some code in there. Any help would be greatly appreciated. |
|
Same problem. 6 months of this PR... Is a dead project? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line is causing many people to stop from being able to deploy. (see this issue #78) Can this be changed to determine whether libpng-dev can be installed on the system and stop the process if it can be installed with a warning to the user to install libpng-dev, else just continue on installing npm packages? It seems that systems with a commad of apt-get have access to libpgn-dev.
This line is literally stopping the deployment of apps on systems where libpng-dev cannot be installed.
I am on CentOS and there is no libpng-dev package for that system.
Thank you!